-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api #17
base: master
Are you sure you want to change the base?
Conversation
layout false | ||
respond_to :json | ||
|
||
rescue_from Exception, with: :internal_error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierce-h is there a reason to rescue Exception
instead of StandardError
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that should be standard error. I'll admit when it comes to catching errors and exceptions I am not 100% confident in my implementation. I have a rough idea of how I think it all should work.
include ApiHelpers | ||
|
||
describe "API::V1" do | ||
before(:each) { host! "api.#{host}" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
teach me what host!
is?
thoughts:
|
No description provided.